Use standard Expander control for review setup page instead of SettingsExpander #161
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
This changes the SettingsExpander control we were using in the review page of the setup flow for a standard Expander control
References and relevant issues
Detailed description of the pull request / Additional comments
There seems to be a bug in the SettingsExpander where it crashes when expanding if the items contained are not SettingsCards (but only when running without a debugger). We had a NavigationPane, so we were being hit by this.
To avoid this, we use a standard Expander control. The downside is that we have to re-do some of the styling manually, as the settings controls already had a good default style.
We could have used a SettingsCard to contain the NavigationPane, but these are intended to be used with a "header" in the left and a "content" in the right, but we wanted to use the full width for the pane.
Validation steps performed
PR checklist