Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standard Expander control for review setup page instead of SettingsExpander #161

Merged
merged 2 commits into from
Apr 6, 2023
Merged

Use standard Expander control for review setup page instead of SettingsExpander #161

merged 2 commits into from
Apr 6, 2023

Conversation

florelis
Copy link
Member

@florelis florelis commented Apr 6, 2023

Summary of the pull request

This changes the SettingsExpander control we were using in the review page of the setup flow for a standard Expander control

References and relevant issues

Detailed description of the pull request / Additional comments

There seems to be a bug in the SettingsExpander where it crashes when expanding if the items contained are not SettingsCards (but only when running without a debugger). We had a NavigationPane, so we were being hit by this.

To avoid this, we use a standard Expander control. The downside is that we have to re-do some of the styling manually, as the settings controls already had a good default style.

We could have used a SettingsCard to contain the NavigationPane, but these are intended to be used with a "header" in the left and a "content" in the right, but we wanted to use the full width for the pane.

image

Validation steps performed

PR checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated

@florelis
Copy link
Member Author

florelis commented Apr 6, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@florelis florelis merged commit e3bd798 into microsoft:main Apr 6, 2023
@florelis florelis deleted the reviewExpander branch April 6, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants