Logging and Telemetry should be combined

[krschau]

Description of the new feature / enhancement

Having two ILoggers is ambiguous.

Scenario when this would be used?

No response

Supporting information

No response

[AmelBawa-msft]

Suggestion:

1. Rename current ILogger to ITelemetry
2. Register both ITelemetry and (the new) ILogger to the Application container
3. Inject ITelemetry into (the new) ILogger since the latter is super set of the former
4. Update (the new) ILogger API to allow log telemetry as argument (e.g. LogError(...., telemetry: None (default) / Local / Info /...))

Challenges that needs to be solved:

• How can we register (the new) ILogger to the Application container while still maintaining the logging namespace (e.g. Dashboard, SetupFlow, etc....).

For example:

public SetupFlowService(ILogger logger)
{
    logger.Info("Hello world"); // [SetupFlow] Hello world
}

public DashboardService(ILogger logger)
{
    logger.Info("Hello world"); // [Dashboard] Hello world
}

CC: @krschau @dkbennett @ujjwalchadha @jamespik @asklar

[florelis]

How can we register (the new) ILogger to the Application container while still maintaining the logging namespace (e.g. Dashboard, SetupFlow, etc....).

I don't think we need DI for this. If I understand correctly the benefits are being able to mock it which I don't think we need for these, and some help with getting the instances where we need them, which can be solved with a singleton like it's currently done for the dashboard.

Logging and Telemetry should be combined

Why not keep them separate? The data needed for the two of them seems quite different. For logging we ultimately want a readable string, whereas for telemetry we want a identifier string plus an object with related data.

[AmelBawa-msft]

Discussed offline, after we have a working PoC of a logger in the SetupFlow, I will think of a way to add it to the DI container so it gets injected into the resolved types constructors.

Related work:

• ILogger<TCategoryName>
• ILoggerFactory

[dhoehna]

@florelis or @AmelBawa-msft can this issue be closed?

[AmelBawa-msft]

I suggest keeping this issue open for now. Telemetry and logging will potentially remain separate, but I still need to look into making the logger available from the container instead of a Log.cs implementations in each project.