-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[catpowder] Bug fix: RSS queue detection issue #1447
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libos = catpowder
|
libos = catnap
|
libos = catnip
|
anandbonde
reviewed
Oct 28, 2024
anandbonde
reviewed
Oct 28, 2024
anandbonde
approved these changes
Oct 28, 2024
kyleholohan
force-pushed
the
bug-fix-kyle-rss-deduction
branch
from
October 29, 2024 19:58
7cdfe7e
to
8f9a1f0
Compare
kyleholohan
force-pushed
the
bug-fix-kyle-rss-deduction
branch
from
October 29, 2024 20:06
8f9a1f0
to
06183a5
Compare
libos = catnip
|
libos = catpowder
|
libos = catnap
|
libos = catnip
|
libos = catpowder
|
libos = catnap
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change RSS queue count detection from using
RxRing
s toTxRing
s.RxRing
s do late-binding validation after the queue is programmed;TxRing
s do immediate validation. This is causing issues with subsequent changes to catpowderW