Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[runtime] Enhancement: Move background coroutines to own group #1296

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

iyzhang
Copy link
Contributor

@iyzhang iyzhang commented May 30, 2024

This PR separates coroutines that perform I/O from background coroutines in the runtime using the new scheduler task groups. Splitting these two lets us distinguish between coroutines where we are waiting on a result and coroutines that run forever. We also have the ability to poll a single coroutine, so we replace our poll on every system call with a poll to the specific coroutine.

@iyzhang iyzhang requested a review from ppenna May 30, 2024 00:09
@iyzhang iyzhang self-assigned this May 30, 2024
Copy link

Processing commits from 7f8103a to 9e1c48f (in the last 15 days)

Performance for Push() in tcp-ping-pong-server

Diff since root commit.

Diff Commit Catnap
0 4270 ffaf885 440.494
1 4272 c420595 447.518
2 4274 71a0b41 517.249
3 4278 9eb25d9 597.617
4 4280 efbd0ae 457.1
5 4285 a15818c 529.453
6 4288 8447e59 492.793
7 4295 c7d634e 464.655
8 4298 c1c9c02 527.795
9 4300 8ef1126 483.754
10 4303 a56e9f9 492.433
11 4307 e967e70 500.828
12 4310 b562c4e 611.054

Performance for Pop() in tcp-ping-pong-server

Diff since root commit.

Diff Commit Catnap
0 4270 ffaf885 388.025
1 4272 c420595 365.31
2 4274 71a0b41 571.701
3 4278 9eb25d9 663.304
4 4280 efbd0ae 405.122
5 4285 a15818c 456.064
6 4288 8447e59 398.106
7 4295 c7d634e 405.709
8 4298 c1c9c02 482.54
9 4300 8ef1126 405.098
10 4303 a56e9f9 424.276
11 4307 e967e70 551.018
12 4310 b562c4e 689.567

Performance for Push() in tcp-ping-pong-client

Diff since root commit.

Diff Commit Catnap
0 4270 ffaf885 476.914
1 4272 c420595 490.128
2 4274 71a0b41 464.041
3 4278 9eb25d9 468.682
4 4280 efbd0ae 477.776
5 4285 a15818c 500.384
6 4288 8447e59 490.102
7 4295 c7d634e 432.513
8 4298 c1c9c02 441.798
9 4300 8ef1126 477.416
10 4303 a56e9f9 491.019
11 4307 e967e70 476.22
12 4310 b562c4e 446.375

Performance for Pop() in tcp-ping-pong-client

Diff since root commit.

Diff Commit Catnap
0 4270 ffaf885 373.839
1 4272 c420595 373.293
2 4274 71a0b41 387.314
3 4278 9eb25d9 380.885
4 4280 efbd0ae 424.6
5 4285 a15818c 433.062
6 4288 8447e59 378.485
7 4295 c7d634e 392.555
8 4298 c1c9c02 397.946
9 4300 8ef1126 372.914
10 4303 a56e9f9 406.028
11 4307 e967e70 409.092
12 4310 b562c4e 392.578

@iyzhang iyzhang force-pushed the enhancement-runtime-background-group branch from 90f8720 to dc90d03 Compare May 30, 2024 17:03
@iyzhang iyzhang marked this pull request as draft May 30, 2024 17:18
Copy link

Processing commits from 7f8103a to dc90d03 (in the last 15 days)

Performance for Push() in tcp-ping-pong-server

Diff since root commit.

Diff Commit Catnap
0 4272 c420595 447.518
1 4274 71a0b41 517.249
2 4278 9eb25d9 597.617
3 4280 efbd0ae 457.1
4 4285 a15818c 529.453
5 4288 8447e59 492.793
6 4295 c7d634e 464.655
7 4298 c1c9c02 527.795
8 4300 8ef1126 483.754
9 4303 a56e9f9 492.433
10 4307 e967e70 500.828
11 4310 b562c4e 611.054

Performance for Pop() in tcp-ping-pong-server

Diff since root commit.

Diff Commit Catnap
0 4272 c420595 365.31
1 4274 71a0b41 571.701
2 4278 9eb25d9 663.304
3 4280 efbd0ae 405.122
4 4285 a15818c 456.064
5 4288 8447e59 398.106
6 4295 c7d634e 405.709
7 4298 c1c9c02 482.54
8 4300 8ef1126 405.098
9 4303 a56e9f9 424.276
10 4307 e967e70 551.018
11 4310 b562c4e 689.567

Performance for Push() in tcp-ping-pong-client

Diff since root commit.

Diff Commit Catnap
0 4272 c420595 490.128
1 4274 71a0b41 464.041
2 4278 9eb25d9 468.682
3 4280 efbd0ae 477.776
4 4285 a15818c 500.384
5 4288 8447e59 490.102
6 4295 c7d634e 432.513
7 4298 c1c9c02 441.798
8 4300 8ef1126 477.416
9 4303 a56e9f9 491.019
10 4307 e967e70 476.22
11 4310 b562c4e 446.375

Performance for Pop() in tcp-ping-pong-client

Diff since root commit.

Diff Commit Catnap
0 4272 c420595 373.293
1 4274 71a0b41 387.314
2 4278 9eb25d9 380.885
3 4280 efbd0ae 424.6
4 4285 a15818c 433.062
5 4288 8447e59 378.485
6 4295 c7d634e 392.555
7 4298 c1c9c02 397.946
8 4300 8ef1126 372.914
9 4303 a56e9f9 406.028
10 4307 e967e70 409.092
11 4310 b562c4e 392.578

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant