Skip to content

Conversation

ppenna
Copy link
Collaborator

@ppenna ppenna commented May 10, 2024

Description

@ppenna ppenna added the bug Something Isn't Working label May 10, 2024
@ppenna ppenna requested a review from iyzhang May 10, 2024 17:26
@ppenna ppenna self-assigned this May 10, 2024
Copy link

Processing commits from 7f8103a to 6d2231b (in the last 15 days)

Performance for Push() in tcp-ping-pong-server

Diff since root commit.

Diff Commit Catnip
0 4184 9f63b76 16125.9
1 4187 85f4c33 14985
2 4200 a0db115 13253.9
3 4202 1550fac 13302.9
4 4204 6f58238 16362.8
5 4208 ebe18f9 14539.4
6 4210 ba498f1 15847
7 4213 bdb1fe0 16584.4
8 4215 18f9299 15716.9
9 4217 c45406c 15605.2
10 4224 598a6de 13856.6
11 4226 5b5bf06 1884.28
12 4228 2b949e3 1940.76
13 4234 cd2a133 1894.4
14 4236 3dee402 3389.54
15 4238 540c178 2034.87
16 4241 fc96ac0 1902.97
17 4244 b7ee223 2101.48
18 4247 dca2919 2106.76
19 4254 c25fdd5 2003.26
20 4258 0fcdcdc 1952.29

Performance for Pop() in tcp-ping-pong-server

Diff since root commit.

Diff Commit Catnip
0 4184 9f63b76 682.659
1 4187 85f4c33 1083.79
2 4200 a0db115 876.968
3 4202 1550fac 877.06
4 4204 6f58238 846.088
5 4208 ebe18f9 961.779
6 4210 ba498f1 842.672
7 4213 bdb1fe0 965.561
8 4215 18f9299 916.696
9 4217 c45406c 1063.19
10 4224 598a6de 836.388
11 4226 5b5bf06 493.454
12 4228 2b949e3 480.252
13 4234 cd2a133 431.12
14 4236 3dee402 937.122
15 4238 540c178 407.989
16 4241 fc96ac0 415.521
17 4244 b7ee223 394.332
18 4247 dca2919 407.457
19 4254 c25fdd5 426.626
20 4258 0fcdcdc 407.535

Performance for Push() in tcp-ping-pong-client

Diff since root commit.

Diff Commit Catnip
0 4184 9f63b76 34666.2
1 4187 85f4c33 21611.1
2 4200 a0db115 16069.1
3 4202 1550fac 15629.4
4 4204 6f58238 17526.1
5 4208 ebe18f9 14327.1
6 4210 ba498f1 15823.4
7 4213 bdb1fe0 17390.6
8 4215 18f9299 15722.9
9 4217 c45406c 13510.4
10 4224 598a6de 15716.7
11 4226 5b5bf06 2524.44
12 4228 2b949e3 2357.02
13 4234 cd2a133 2234.82
14 4236 3dee402 2195.04
15 4238 540c178 1735.34
16 4241 fc96ac0 1696.62
17 4244 b7ee223 1758.94
18 4247 dca2919 1795.06
19 4254 c25fdd5 1729.9
20 4258 0fcdcdc 1714.5

Performance for Pop() in tcp-ping-pong-client

Diff since root commit.

Diff Commit Catnip
0 4184 9f63b76 1929.01
1 4187 85f4c33 1228.61
2 4200 a0db115 884.912
3 4202 1550fac 893.596
4 4204 6f58238 917.072
5 4208 ebe18f9 990.465
6 4210 ba498f1 1004.51
7 4213 bdb1fe0 922.154
8 4215 18f9299 756.708
9 4217 c45406c 840.774
10 4224 598a6de 950.586
11 4226 5b5bf06 506.008
12 4228 2b949e3 469.568
13 4234 cd2a133 440.835
14 4236 3dee402 469.367
15 4238 540c178 386.665
16 4241 fc96ac0 387.502
17 4244 b7ee223 389.141
18 4247 dca2919 382.631
19 4254 c25fdd5 391.914
20 4258 0fcdcdc 390.17

Copy link

Processing commits from 7f8103a to 6d2231b (in the last 15 days)

Performance for Push() in tcp-ping-pong-server

Diff since root commit.

Diff Commit Catpowder
0 4184 9f63b76 12739.8
1 4187 85f4c33 11084.1
2 4200 a0db115 9770.92
3 4202 1550fac 10305.9
4 4204 6f58238 10951.8
5 4208 ebe18f9 14437.1
6 4210 ba498f1 10089.2
7 4213 bdb1fe0 10408.3
8 4215 18f9299 10584.9
9 4217 c45406c 9789.86
10 4224 598a6de 11003.3
11 4226 5b5bf06 6139.54
12 4228 2b949e3 6108.88
13 4234 cd2a133 6068.32
14 4236 3dee402 5697.58
15 4238 540c178 5258.1
16 4241 fc96ac0 5206.82
17 4244 b7ee223 5125.77
18 4247 dca2919 7239.47
19 4254 c25fdd5 6025.63
20 4258 0fcdcdc 6076.47
21 4264 6d2231b 19547.2

Performance for Pop() in tcp-ping-pong-server

Diff since root commit.

Diff Commit Catpowder
0 4184 9f63b76 1003.32
1 4187 85f4c33 894.053
2 4200 a0db115 1274.74
3 4202 1550fac 944.838
4 4204 6f58238 804.682
5 4208 ebe18f9 1753.97
6 4210 ba498f1 770.618
7 4213 bdb1fe0 1297.25
8 4215 18f9299 872.733
9 4217 c45406c 921.789
10 4224 598a6de 1242.28
11 4226 5b5bf06 458.145
12 4228 2b949e3 430.218
13 4234 cd2a133 433.72
14 4236 3dee402 476.449
15 4238 540c178 440.223
16 4241 fc96ac0 433.896
17 4244 b7ee223 460.887
18 4247 dca2919 570.242
19 4254 c25fdd5 502.417
20 4258 0fcdcdc 446.953
21 4264 6d2231b 673.544

Performance for Push() in tcp-ping-pong-client

Diff since root commit.

Diff Commit Catpowder
0 4184 9f63b76 10576.2
1 4187 85f4c33 9832.18
2 4200 a0db115 11629.5
3 4202 1550fac 11127.2
4 4204 6f58238 11870.9
5 4208 ebe18f9 10144.2
6 4210 ba498f1 10978.2
7 4213 bdb1fe0 18161.5
8 4215 18f9299 10530.1
9 4217 c45406c 11690.4
10 4224 598a6de 10958.6
11 4226 5b5bf06 6365.38
12 4228 2b949e3 10184.6
13 4234 cd2a133 6353.37
14 4236 3dee402 6178.99
15 4238 540c178 5592.41
16 4241 fc96ac0 5860.03
17 4244 b7ee223 6849.73
18 4247 dca2919 6351.2
19 4254 c25fdd5 6326.4
20 4258 0fcdcdc 8355.7
21 4264 6d2231b 6215.36

Performance for Pop() in tcp-ping-pong-client

Diff since root commit.

Diff Commit Catpowder
0 4184 9f63b76 773.399
1 4187 85f4c33 805.228
2 4200 a0db115 1048.4
3 4202 1550fac 690.888
4 4204 6f58238 1179.14
5 4208 ebe18f9 806.66
6 4210 ba498f1 832.631
7 4213 bdb1fe0 1564.42
8 4215 18f9299 803.969
9 4217 c45406c 827.955
10 4224 598a6de 711.448
11 4226 5b5bf06 433.13
12 4228 2b949e3 643.435
13 4234 cd2a133 418.845
14 4236 3dee402 433.43
15 4238 540c178 422.624
16 4241 fc96ac0 418.76
17 4244 b7ee223 573.35
18 4247 dca2919 435.835
19 4254 c25fdd5 438.997
20 4258 0fcdcdc 561.341
21 4264 6d2231b 461.738

Copy link

Processing commits from 7f8103a to 6d2231b (in the last 15 days)

Performance for Push() in tcp-ping-pong-server

Diff since root commit.

Diff Commit Catnap
0 4184 9f63b76 975.729
1 4187 85f4c33 995.858
2 4200 a0db115 884.367
3 4202 1550fac 1100.64
4 4204 6f58238 805.667
5 4208 ebe18f9 1000.13
6 4210 ba498f1 1014.26
7 4213 bdb1fe0 1029.13
8 4215 18f9299 1194.43
9 4217 c45406c 960.412
10 4224 598a6de 1005.39
11 4226 5b5bf06 458.344
12 4228 2b949e3 467.436
13 4234 cd2a133 513.478
14 4236 3dee402 442.857
15 4238 540c178 529.396
16 4241 fc96ac0 480.166
17 4244 b7ee223 507.442
18 4247 dca2919 489.056
19 4254 c25fdd5 476.425
20 4258 0fcdcdc 485.282
21 4264 6d2231b 472.832

Performance for Pop() in tcp-ping-pong-server

Diff since root commit.

Diff Commit Catnap
0 4184 9f63b76 1446.34
1 4187 85f4c33 900.466
2 4200 a0db115 975.55
3 4202 1550fac 1148.74
4 4204 6f58238 894.426
5 4208 ebe18f9 1050.39
6 4210 ba498f1 1295.3
7 4213 bdb1fe0 1341.39
8 4215 18f9299 1354.71
9 4217 c45406c 900.234
10 4224 598a6de 757.57
11 4226 5b5bf06 400.688
12 4228 2b949e3 418.063
13 4234 cd2a133 431.499
14 4236 3dee402 409.513
15 4238 540c178 823.94
16 4241 fc96ac0 392.997
17 4244 b7ee223 404.813
18 4247 dca2919 362.229
19 4254 c25fdd5 449.675
20 4258 0fcdcdc 423.344
21 4264 6d2231b 375.373

Performance for Push() in tcp-ping-pong-client

Diff since root commit.

Diff Commit Catnap
0 4184 9f63b76 968.569
1 4187 85f4c33 917.172
2 4200 a0db115 749.999
3 4202 1550fac 859.071
4 4204 6f58238 939.035
5 4208 ebe18f9 795.583
6 4210 ba498f1 2111.2
7 4213 bdb1fe0 1996.26
8 4215 18f9299 952.25
9 4217 c45406c 902.158
10 4224 598a6de 991.789
11 4226 5b5bf06 519.622
12 4228 2b949e3 501.764
13 4234 cd2a133 532.052
14 4236 3dee402 497.652
15 4238 540c178 472.631
16 4241 fc96ac0 498.244
17 4244 b7ee223 490.868
18 4247 dca2919 470.253
19 4254 c25fdd5 445.935
20 4258 0fcdcdc 477.221
21 4264 6d2231b 472.581

Performance for Pop() in tcp-ping-pong-client

Diff since root commit.

Diff Commit Catnap
0 4184 9f63b76 729.928
1 4187 85f4c33 687.956
2 4200 a0db115 667.861
3 4202 1550fac 695.435
4 4204 6f58238 668.725
5 4208 ebe18f9 686.287
6 4210 ba498f1 1037.21
7 4213 bdb1fe0 636.699
8 4215 18f9299 766.438
9 4217 c45406c 625.103
10 4224 598a6de 644.826
11 4226 5b5bf06 396.44
12 4228 2b949e3 413.111
13 4234 cd2a133 592.77
14 4236 3dee402 442.926
15 4238 540c178 384.613
16 4241 fc96ac0 397.613
17 4244 b7ee223 375.974
18 4247 dca2919 385.9
19 4254 c25fdd5 366.234
20 4258 0fcdcdc 379.738
21 4264 6d2231b 402.37

Copy link
Contributor

@iyzhang iyzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing this.

@ppenna ppenna merged commit e3f3442 into dev May 14, 2024
@ppenna ppenna deleted the bugfix-pdpix-sockopt branch May 14, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something Isn't Working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[libos] Disallow Setting SO_LINGER When Socket is Closing
2 participants