Account for the scope when changing variables #1869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchiodo
commented
Mar 10, 2025
| @@ -934,7 +934,7 @@ def internal_change_variable_json(py_db, request): | |||
| ) | |||
| return | |||
|
|
|||
| child_var = variable.change_variable(arguments.name, arguments.value, py_db, fmt=fmt) | |||
| child_var = variable.change_variable(arguments.name, arguments.value, py_db, fmt=fmt, scope=scope) | |||
There was a problem hiding this comment.
This is where the setVariable request is handled. I added the scope to the change_variable
debonte
reviewed
Mar 10, 2025
src/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_plugin_utils.py
Outdated
Show resolved
Hide resolved
src/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_suspended_frames.py
Outdated
Show resolved
Hide resolved
debonte
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this issue:
#1857
The user is trying to assign the global 'c' to a new value while inside of a function. Since the variable is listed under 'globals', you'd think this would just work.
Internally we don't actually assign it to globals unless the user types
globals()['c']=value, but that doesn't really make sense from the variables panel.I found that the scope of the variable is passed in the
setVariablesrequest, so we can use that to determine if the variable was originally a global or not and assign it to the correct scope.I tested this with Pydevd's test automation and by using VS code.
Addresses #1857