manylinux wheels don't pass auditwheel checks

[SylvainCorlay]

Environment data

• PTVSD version: 4.3.2 (latest)
• OS and version: Manylinux1
• Python version (& distribution if applicable, e.g. Anaconda): Any

Actual behavior

auditwheel fails on ptvsd's maynlinux wheels with

RuntimeError: Invalid binary wheel, found the following shared library/libraries in purelib folder:
	pydevd_cython.cpython-35m-x86_64-linux-gnu.so
	attach_linux_amd64.so
	attach_linux_x86.so

[int19h]

I don't think this causes any actual problems, because we load all that code conditionally, so on any platform for which those binaries aren't compiled, the debugger still works as a pure Python library, although functionality may be reduced (e.g. no attach-to-PID).

That said, we should try to fix the warning. This may be tricky because of how we are packaging our vendored copy of pydevd, though.

[int19h]

It still applies to debugpy, so moving it to that repo.

[SylvainCorlay]

You may eventually need to fix it. I have read in a couple of places that the pypi folks were looking into running such checks to accept binary wheels.

[SylvainCorlay]

Note that this is not an issue for us. I came across this as I was running auditwheel on xeus-python, for the Jupyter debugger.

[int19h]

Turns out that those warnings are not entirely spurious. We messed up the packaging such that all our stuff goes inside purelib in the wheel, which is in violation of the manylinux PEP requirements.

Furthermore, for the attach helper .so, we have some non-conformant dependencies (glibc version) - but the codepath that conditionally loads them only checks arch, not glibc. So it's possible to install that wheel in an environment that is supposed to be able to run manylinux1 binaries, and then have it fail at runtime (instead of fallback), if you use attach-to-PID.