Moving Agents Out of Froggy #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xingdi-eric-yuan
force-pushed
the
move_agents
branch
2 times, most recently
from
d819abf to
500eba4
Compare
xingdi-eric-yuan
force-pushed
the
move_agents
branch
from
500eba4 to
3bbcfd8
Compare
MarcCote
reviewed
Feb 5, 2025
scripts/run.py
Outdated
Comment on lines
96
to
101
| case "pdb_agent": | ||
| from agent import PdbAgent as agent_class | ||
| case "rewrite_only": | ||
| from agent import RewriteOnly as agent_class | ||
| case "pdb_after_rewrites": | ||
| from agent import PdbAfterRewrites as agent_class |
There was a problem hiding this comment.
This assumes we are running the script from the root of the repo. Also, this assumes there's no python library called agent installed on the system. That's okay with me, I don't know what's the proper to deal with that setup.
There was a problem hiding this comment.
Maybe rename agent -> example_agent so these example code can coexist with users' agents.
MarcCote
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to merge #42 first.
AgentZeroShot->PdbAgent,AgentZeroShot_NoPDB->RewriteOnly,AgentZeroShot_PdbAfterRewrites->PdbAfterRewrites.