pass entrypoint properly for aider #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcCote
reviewed
Nov 28, 2024
MarcCote
approved these changes
Nov 28, 2024
|
I'm ok with the changes, but that wouldn't extend to other benchmarks, eg. swe-bench needs to define a custom entrypoint for each problem. |
matheper
reviewed
Nov 28, 2024
froggy/envs/env.py
Outdated
| @@ -122,12 +124,11 @@ def setup_workspace( | |||
| self.editable_files = [ | |||
| p for p in self.all_files if not self.is_readonly(self.working_dir / p) | |||
| ] | |||
| assert entrypoint.split()[0] == "python", "Only support python entrypoint for now." | |||
There was a problem hiding this comment.
SWE need setup_workspace to set the new entrypoint. There's no way to know the entrypoint until you know the example you are trying to solve.
There was a problem hiding this comment.
Oh and also I guess that assert won't work with with swe-bench :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.