Adding additional setup information #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the images to the setup file
JSON Files step by step. Adding images
adding the ```python
adding the links to the setup docs and working on the readme
|
Adding setup information and readme information: Docs folder
|
remove additional libraries. no need
removed synapse
arjendev
reviewed
Dec 15, 2023
There was a problem hiding this comment.
Thanks @LiliamLeme !!
Sharing some initial comments, will do another review once they have been addressed :)
removing manual copy of fabric json adding the git integration docs
fixing poetry reference
coma missing
removing #
add more information isntead of suggestion
updating the PR feedbacks
small typo
another reference forgotten
ydaponte
previously approved these changes
Dec 21, 2023
There was a problem hiding this comment.
@LiliamLeme - I'm approving not to block the PR - but please address the image comment before merging. Other than that LGTM. Thanks!
arjendev
requested changes
Dec 21, 2023
adding image from image folder
adding images from the folder
Co-authored-by: Yennifer Santos <46519584+ydaponte@users.noreply.github.com>
Co-authored-by: Yennifer Santos <46519584+ydaponte@users.noreply.github.com>
Co-authored-by: Yennifer Santos <46519584+ydaponte@users.noreply.github.com>
Co-authored-by: Yennifer Santos <46519584+ydaponte@users.noreply.github.com>
no capital letter
non capital letter
non capital letters
arjendev
reviewed
Dec 22, 2023
non capital letters
arjendev
reviewed
Dec 22, 2023
fix references
arjendev
reviewed
Dec 22, 2023
arjendev
reviewed
Dec 22, 2023
remove the code
ydaponte
reviewed
Dec 22, 2023
fixing the number that were not in the right order adding link to the folder example reference instead of listing the code
[examples](/examples)
typos and number sequence
adjusting the link for examples -> [examples](/examples)
arjendev
approved these changes
Dec 22, 2023
|
mering readme |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding setup information and readme information:
Docs folder
3)link to this information in the readme