Open
Conversation
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a comprehensive migration plan for transitioning the media streaming protocol from the legacy 5-byte
STARTdiscovery model to a new, configurable 3-way handshake mechanism (SYN / SYN-ACK / ACK). The migration is designed to be backward compatible, with the new behavior gated behind a runtime flag, ensuring existing deployments are unaffected unless explicitly enabled. The plan details the steps, file locations, implementation guidance, and testing strategies required for a safe and incremental rollout.The most important changes are:
Protocol and Handshake Implementation:
c_udpDatagramFlagSyn,c_udpDatagramFlagSynAck,c_udpDatagramFlagAck) and helper functions (MakeSynTask,MakeSynAckTask,MakeAckTask,ParseControlFrame) to support the new handshake, with implementations inctsMediaStreamProtocol.hppandctsMediaStreamProtocol.cpp.ctsIOPatternMediaStream.cppto optionally send a headeredSYNcontrol frame when the 3-way handshake is enabled, while preserving the legacySTARTbehavior by default.**Configuration and Back