Skip to content

Fix narrowing conversion warnings on Windows. #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2018
Merged

Fix narrowing conversion warnings on Windows. #895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Release/src/http/client/http_client_winhttp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1583,7 +1583,7 @@ class winhttp_client final : public _http_client_communicator
else if (length > p_request_context->m_remaining_to_write)
{
// The stream grew, but we won't
length = p_request_context->m_remaining_to_write;
length = static_cast<size_t>(p_request_context->m_remaining_to_write);
}

do_compress(pplx::task_from_result<size_t>(length)).then(after_read);
Expand Down
2 changes: 1 addition & 1 deletion Release/src/http/common/http_msg.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ size_t http_msg_base::_get_stream_length()
auto offset = stream.tell();
auto end = stream.seek(0, std::ios_base::end);
stream.seek(offset);
return static_cast<utility::size64_t>(end - offset);
return static_cast<size_t>(end - offset);
}

return std::numeric_limits<size_t>::max();
Expand Down