Skip to content

Ignore a bunch of temporary files from cmake/ninja. #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2017
Merged

Ignore a bunch of temporary files from cmake/ninja. #488

merged 1 commit into from
Jun 28, 2017

Conversation

kiyolee
Copy link

@kiyolee kiyolee commented Jun 27, 2017

Ignore a bunch of temporary files from cmake/ninja.

@msftclas
Copy link

@kiyolee,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@msftclas
Copy link

@kiyolee, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

@ras0219-msft ras0219-msft merged commit 410feb1 into microsoft:master Jun 28, 2017
@ras0219-msft
Copy link
Contributor

Thanks!

We would highly recommend that you use a separate build directory as well.

@kiyolee kiyolee deleted the ignore-cmake-temp-files branch June 28, 2017 22:49
@kiyolee
Copy link
Author

kiyolee commented Jun 29, 2017

Just figured cmake works differently for these 2 different commands:
(a) cmake {dir}/CMakeLists.txt
(b) cmake {dir}
I accidentally (kind of) used the first form (that ended up not generating cmake files in its own build directory) and so lead to this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants