Skip to content

Fixed test_runner build when BUILD_SHARED_LIBS=OFF #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2017
Merged

Fixed test_runner build when BUILD_SHARED_LIBS=OFF #487

merged 1 commit into from
Jun 28, 2017

Conversation

kiyolee
Copy link

@kiyolee kiyolee commented Jun 27, 2017

test_running always needs linking to libdl.
Found the problem when building static library on RedHat 7.

@msftclas
Copy link

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@msftclas
Copy link

@kiyolee, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

@ras0219-msft ras0219-msft merged commit b77c773 into microsoft:master Jun 28, 2017
@ras0219-msft
Copy link
Contributor

Thanks!

@kiyolee kiyolee deleted the fix-static-build-test_running branch June 28, 2017 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants