Skip to content

fix build on linux use clang #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2017
Merged

fix build on linux use clang #465

merged 1 commit into from
Jul 12, 2017

Conversation

fcharlie
Copy link

@fcharlie fcharlie commented Jun 7, 2017

When use clang build on cpprestsdk on Linux, The original CMakeLists will automatically add the parameter -stdlib=c++ if boost is not built using libc++, then the entire project will fail to build.

For almost all Linux distributions,When the boost that is installed through the Package Manager is using GNU libstdc++ and not clang libc++.

This PR will remove -stdlib=libc++ on linux.

Thanks all.

@msftclas
Copy link

msftclas commented Jun 7, 2017

@fcharlie,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@fcharlie
Copy link
Author

fcharlie commented Jun 7, 2017

signed the CLA

@msftclas
Copy link

msftclas commented Jun 7, 2017

@fcharlie, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

@ras0219-msft
Copy link
Contributor

Thanks, looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants