Skip to content

Fix http_client test case compile failure #1288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 19, 2019
Merged

Fix http_client test case compile failure #1288

merged 2 commits into from
Dec 19, 2019

Conversation

garethsb
Copy link
Contributor

Fixes compile failure with CPPREST_FORCE_HTTP_LISTENER_ASIO on Windows introduced in #1182.

@garethsb
Copy link
Contributor Author

CI test failures seem to be unrelated to the PR, e.g. vcpkg build problems.

BillyONeal
BillyONeal approved these changes Dec 17, 2019
View reviewed changes
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@BillyONeal BillyONeal merged commit e7c6b08 into microsoft:master Dec 19, 2019
@garethsb garethsb deleted the garethsb-fix-http_client-test branch February 27, 2020 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyONeal BillyONeal BillyONeal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@garethsb @BillyONeal