Skip to content

Fix DLL export attribute order for clang on Windows #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 25, 2023
Merged

Fix DLL export attribute order for clang on Windows #292

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e7cd10e
Reorder export/nodiscard attributes for winclang
wravery Jun 12, 2023
f4ec887
Missed method in regex search/replace
wravery Jun 12, 2023
d24f190
vcpkg x-update-baseline --add-initial-baseline
wravery Jun 17, 2023
68d44a7
Rollback to last known commit in macOS vcpkg
wravery Jun 17, 2023
3f1efc7
Fix JSONResponse.h missed in regex replace
wravery Jun 17, 2023
5164d88
Use custom rules for RC files with x64-Clang configs in VS
wravery Jun 17, 2023
ad194d5
Detect toolchains that don't support co_await in Boost.Asio
wravery Jun 25, 2023
1d54869
Bump the patch version
wravery Jun 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Missed method in regex search/replace
  • Loading branch information
@wravery
wravery committed Jun 12, 2023
commit f4ec887acc53758b51baabb42bc1f3791dfef5a8
4 changes: 2 additions & 2 deletions include/graphqlservice/GraphQLService.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1494,8 +1494,8 @@ class [[nodiscard("unnecessary construction")]] Request
[[nodiscard("unnecessary call")]] GRAPHQLSERVICE_EXPORT std::list<schema_error> validate(
peg::ast& query) const;

GRAPHQLSERVICE_EXPORT
[[nodiscard("unnecessary call")]] std::pair<std::string_view, const peg::ast_node*>
[[nodiscard("unnecessary call")]] GRAPHQLSERVICE_EXPORT std::pair<std::string_view,
const peg::ast_node*>
findOperationDefinition(peg::ast& query, std::string_view operationName) const;

[[nodiscard("unnecessary call")]] GRAPHQLSERVICE_EXPORT response::AwaitableValue resolve(
Expand Down