Miscellaneous cleanup getting ready for 3.4.0 release #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the docs got a little out of date since 3.0.0, and in a couple of cases while updating them I noticed typos or other spots where it no longer behaved the way I expected. In particular, the parsing fallbacks for mixed documents were inconsistent and didn't recognize everything they should.
I also decided to add some parameter validation to
Request::deliverafter writing in the docs that it would throw an exception if you didn't pass asubscriptionObjectas either the default or as an override todeliver. It probably would have thrown an exception in either of those cases, but it might have also just run off the end of a vector iterator or dereferenced nullptr, neither of which would have been particularly easy to diagnose. This way seems a little friendlier to me.The last change worth mentioning was updating all of the https://facebook.github.io/graphql/June2018/ references in code or documentation to point to their new home at http://spec.graphql.org/June2018/.