Skip to content

Remove outdated UploadNow comments #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions examples/cpp/SampleCpp/DebugCallback.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -152,9 +152,7 @@ void MyDebugEventListener::OnDebugEvent(DebugEvent& evt)
case EVT_STORAGE_FULL:
printf("OnStorageFull: seq=%llu, ts=%llu, type=0x%08x, p1=%zu, p2=%zu\n", evt.seq, evt.ts, evt.type, evt.param1, evt.param2);
if (evt.param1 >= 75) {
// UploadNow must NEVER EVER be called from SDK callback thread, so either use this structure below
// or notify the main app that it has to do the profile timers housekeeping / force the upload...
std::thread([]() { LogManager::UploadNow(); }).detach();
LogManager::UploadNow();
}
break;

Expand Down
4 changes: 1 addition & 3 deletions examples/cpp/SampleCppUWP/Main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -136,9 +136,7 @@ class MyDebugEventListener : public DebugEventListener {
case EVT_STORAGE_FULL:
printf("OnStorageFull: seq=%llu, ts=%llu, type=0x%08x, p1=%u, p2=%u\n", evt.seq, evt.ts, evt.type, evt.param1, evt.param2);
if (evt.param1 >= 75) {
// UploadNow must NEVER EVER be called from Telemetry callback thread, so either use this structure below
// or notify the main app that it has to do the profile timers housekeeping / force the upload...
std::thread([]() { LogManager::UploadNow(); }).detach();
LogManager::UploadNow();
}
break;

Expand Down
4 changes: 1 addition & 3 deletions tests/functests/EventDecoderListener.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -123,9 +123,7 @@ void EventDecoderListener::OnDebugEvent(DebugEvent &evt)
case EVT_STORAGE_FULL:
PrintEvent("EVT_STORAGE_FULL", evt);
if (evt.param1 >= 75) {
// UploadNow must NEVER EVER be called from Aria callback thread, so either use this structure below
// or notify the main app that it has to do the profile timers housekeeping / force the upload...
std::thread([]() { LogManager::UploadNow(); }).detach();
LogManager::UploadNow();
}
break;

Expand Down