Skip to content

Conversation

@melotic
Copy link
Member

@melotic melotic commented Jan 30, 2023

This PR fixes some of the warnings from #202

  • CA1018
  • CA1032
  • CA1033
  • CA1052
  • CA1401
  • CA1508
  • CA1725
  • CA1725
  • CA1805
  • CA1813
  • CA1816
  • CA1822
  • CA1825
  • CA1835
  • CA1836
  • CA1838
  • CA2016
  • CA2101
  • CA2201
  • CA2208
  • CA2234
  • CA2249
  • CA5392
  • SA1200
  • VSTHRD200

@melotic melotic requested a review from a team as a code owner January 30, 2023 21:52
@melotic melotic requested a review from jcfiorenzano January 30, 2023 21:52
@melotic melotic changed the title Fix some analyzer awrnings Fix some analyzer warnings Jan 30, 2023
@JamieMagee
Copy link
Member

Can you revert the commit for CA1822. It's going to massively conflict with #412

@melotic
Copy link
Member Author

melotic commented Jan 30, 2023

Can you revert the commit for CA1822. It's going to massively conflict with #412

Done.

@github-actions
Copy link

github-actions bot commented Jan 30, 2023

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

@melotic melotic enabled auto-merge (squash) January 31, 2023 16:43
@melotic melotic merged commit 4e49e43 into main Jan 31, 2023
@melotic melotic deleted the justinperez/analyzer-warnings-2 branch January 31, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants