Skip to content

Conversation

@brettfo
Copy link
Member

@brettfo brettfo commented May 5, 2025

package.json files seen in the wild have had a string array instead of an object for the engines property (example here). Because of this, anything that pulls in one of these variant packages will fail to generate components.

While engines should be an object, this PR allows for this alternate form to allow detection to continue.

Fixes #1385

@brettfo brettfo requested a review from a team as a code owner May 5, 2025 19:05
@brettfo brettfo requested a review from pauld-msft May 5, 2025 19:05
@codecov
Copy link

codecov bot commented May 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.6%. Comparing base (b6bac81) to head (39de530).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1400   +/-   ##
=====================================
  Coverage   89.6%   89.6%           
=====================================
  Files        401     401           
  Lines      31811   31875   +64     
  Branches    1966    1972    +6     
=====================================
+ Hits       28528   28591   +63     
  Misses      2863    2863           
- Partials     420     421    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JamieMagee JamieMagee merged commit a6f008f into microsoft:main May 5, 2025
23 checks passed
@github-actions
Copy link

github-actions bot commented May 5, 2025

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Npm exception for "vscode" invalid key value

2 participants