Update RustCli Parsing to process pkgId, and introduce manual override#1106
Merged
Conversation
… fallback with DisableRustCliScan
|
👋 Hi! It looks like you modified some files in the
If none of the above scenarios apply, feel free to ignore this comment 🙂 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1106 +/- ##
=======================================
+ Coverage 75.7% 75.9% +0.2%
=======================================
Files 239 247 +8
Lines 10822 11089 +267
Branches 1086 1137 +51
=======================================
+ Hits 8193 8419 +226
- Misses 2317 2347 +30
- Partials 312 323 +11 ☔ View full report in Codecov by Sentry. |
FernandoRojo
commented
May 14, 2024
cobya
reviewed
May 14, 2024
Contributor
|
@FernandoRojo to verify, the new locations in snapshot verification are expected correct? |
cobya
approved these changes
May 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows users to manually override rustCLI detector by setting an environment variable DisableRustCliScan=True
Updates cargo metadata output processing to adhere to changes introduced that make the output follow the PkgId Spec: https://doc.rust-lang.org/cargo/reference/pkgid-spec.html
Changes to the metadata output were introduced in 1.77: rust-lang/cargo#12914