Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Define [com_interface] IID as string #107

Merged
merged 3 commits into from
Nov 18, 2019
Merged

Conversation

Rantanen
Copy link
Contributor

Define the GUID as a string in the #[com_interface("<iid>")] attributes.

Needed something easy and simple to work on. :)

Closes #90

@Rantanen
Copy link
Contributor Author

The CI is private by the way. I forgot to run rustfmt on the changes, which resulted in a failing CI build, but all I get is access denied when trying to access it:
https://dev.azure.com/microsoft-rust/332945ff-0d35-4cde-b1e2-30e171b5154d/_build/results?buildId=353

Copy link
Contributor

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rantanen awesome - thanks! Any way we could add a compile check to make sure we get a nice error message when not using a string literal?

@Rantanen
Copy link
Contributor Author

Added that test and rebased on top of the master branch to resolve conflict in progress.rs and to fix the path tests, which need to use string GUIDs in this branch.

@Rantanen
Copy link
Contributor Author

I don't really know what is causing the build failure here. I've tried replicating the .azure-pipelines.yml build locally and I can't get it to fail. I'll try fixing the timestamp on the last commit, which is at least confusing GitHub (since due to rebasing things, it's timestamp is before the second last commit).

@Rantanen
Copy link
Contributor Author

There was an error in the tests. Apparently I had mixed the old pre-string path tests and this one when verifying that the errors were correct. Instead the new test failed to compile due to missing use and now because of non-string GUID parameter.

Fixed that and now the CI is green as well. Still no idea what the original issue was though. :|

@Rantanen Rantanen requested a review from rylev November 18, 2019 18:33
@rylev rylev merged commit 339a5a8 into microsoft:master Nov 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider writing GUIDs as strings in attribute macros
2 participants