-
Notifications
You must be signed in to change notification settings - Fork 55
Conversation
3479d0c
to
5ff9a8d
Compare
The CI is private by the way. I forgot to run rustfmt on the changes, which resulted in a failing CI build, but all I get is access denied when trying to access it: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rantanen awesome - thanks! Any way we could add a compile check to make sure we get a nice error message when not using a string literal?
5ff9a8d
to
456cb5e
Compare
Added that test and rebased on top of the master branch to resolve conflict in progress.rs and to fix the path tests, which need to use string GUIDs in this branch. |
I don't really know what is causing the build failure here. I've tried replicating the |
456cb5e
to
eff306a
Compare
eff306a
to
a10889a
Compare
There was an error in the tests. Apparently I had mixed the old pre-string path tests and this one when verifying that the errors were correct. Instead the new test failed to compile due to missing Fixed that and now the CI is green as well. Still no idea what the original issue was though. :| |
Define the GUID as a string in the
#[com_interface("<iid>")]
attributes.Needed something easy and simple to work on. :)
Closes #90