Skip to content

PS: Also handle -q and -i arguments in sql injection query #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MathiasVP merged 4 commits into from
Sep 2, 2025
Merged

PS: Also handle -q and -i arguments in sql injection query #276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6501d12
PS: Add false positive.
MathiasVP Sep 2, 2025
b5fb6b5
PS: Fix FP by also considering -q and -i parameters.
MathiasVP Sep 2, 2025
cfbde9a
PS: Accept test changes.
MathiasVP Sep 2, 2025
b475871
Merge branch 'main' into powershell-sql-injection-alias-parameter-fp
chanel-y Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions powershell/ql/lib/semmle/code/powershell/security/SqlInjectionCustomizations.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,15 +48,19 @@ module SqlInjection {
override string getSourceType() { result = this.(SourceNode).getSourceType() }
}

private string query() { result = ["query", "q"] }

private string inputfile() { result = ["inputfile", "i"] }

class InvokeSqlCmdSink extends Sink {
InvokeSqlCmdSink() {
exists(DataFlow::CallNode call | call.matchesName("Invoke-Sqlcmd") |
this = call.getNamedArgument("query")
this = call.getNamedArgument(query())
or
this = call.getNamedArgument("inputfile")
this = call.getNamedArgument(inputfile())
or
not call.hasNamedArgument("query") and
not call.hasNamedArgument("inputfile") and
not call.hasNamedArgument(query()) and
not call.hasNamedArgument(inputfile()) and
this = call.getArgument(0)
or
// TODO: Here we really should pick a splat argument, but we don't yet extract whether an
Expand Down
3 changes: 3 additions & 0 deletions powershell/ql/test/query-tests/security/cwe-089/test.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,3 +107,6 @@ function TakesTypedParameters([int]$i, [long]$l, [float]$f, [double]$d, [decimal
}

TakesTypedParameters $userinput $userinput $userinput $userinput $userinput $userinput $userinput $userinput

$query = "SELECT * FROM MyTable WHERE MyColumn = '$userinput'"
Invoke-Sqlcmd -unknown $userinput -ServerInstance "MyServer" -Database "MyDatabase" -q "SELECT * FROM MyTable" # GOOD
Loading