PS: Add simple type-based sanitizer to SQL injection query #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm + down to add this to the command injection query! |
chanel-y
approved these changes
Jul 24, 2025
Collaborator
Author
|
Oops. Looks like I broke some stuff. Yay for tests and CI! Will take a look now! |
Collaborator
Author
chanel-y
approved these changes
Jul 24, 2025
dilanbhalla
pushed a commit
that referenced
this pull request
Aug 8, 2025
PS: Add simple type-based sanitizer to SQL injection query
dilanbhalla
pushed a commit
that referenced
this pull request
Aug 8, 2025
PS: Add simple type-based sanitizer to SQL injection query
dilanbhalla
pushed a commit
that referenced
this pull request
Aug 8, 2025
PS: Add simple type-based sanitizer to SQL injection query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a class similar to C#'s SimpleTypeSanitizedExpr which blocks flow out of types for which we generally don't care about flow into. Similar to C#'s I've picked integer/floating point, booleans, and date time types.
Finally, the PR also adds this barrier to the SQL injection query. The command-injection query already has a similar sanitizer which blocks flow on all parameters without the
Objecttype.@chanel-y I don't know if we want to use this sanitizer instead of the one you've added in the command-injection query, or whether it's better to keep the current sanitizer?