Mono.Cecil fails to load when using Microsoft.Testing.Platform on net472

[MattKotsenas]

I'm attempting to adopt Microsoft.Testing.Platform and with it the new Microsoft.Testing.Extensions.CodeCoverage, however net472 tests all fail to run with the error

Unhandled Exception: System.IO.FileLoadException: Could not load file or assembly 'Mono.Cecil, Version=0.11.5.0, Culture=neutral, PublicKeyToken=50cebf1cceb9d05e' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)

Repro steps

Tests.cs

using Xunit;

public sealed class Tests
{
    [Fact]
    public void MyTest()
    {
        Assert.True(true);
    }
}

Tests.csproj

<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <TargetFrameworks>net472;net8.0</TargetFrameworks>
    <TestProject>true</TestProject>
    <OutputType>Exe</OutputType>
    <UseMicrosoftTestingPlatformRunner>true</UseMicrosoftTestingPlatformRunner>
    <TestingPlatformDotnetTestSupport>true</TestingPlatformDotnetTestSupport>
    <TestingPlatformShowTestsFailure>true</TestingPlatformShowTestsFailure>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="FluentAssertions" Version="7.2.0"/>
    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.13.0"/>
    <PackageReference Include="Microsoft.Testing.Extensions.CodeCoverage" Version="17.13.1" />
    <PackageReference Include="Microsoft.Testing.Extensions.TrxReport" Version="1.6.2" />
    <PackageReference Include="Moq" Version="4.20.72"/>
    <PackageReference Include="Moq.Analyzers" Version="0.3.0"/>
    <PackageReference Include="xunit.v3" Version="2.0.0"/>
    <PackageReference Include="xunit.runner.visualstudio" Version="3.0.2"/>
  </ItemGroup>

</Project>

and then run dotnet test -- --coverage --coverage-output-format cobertura

Additional info

.NET SDK 9.0.201
Windows 11 24H2 OS Build 26100.3476

[fhnaseer]

There is a mismatch of mono.cecil version in xunit.v3 and Microsoft.Testing.Extensions.CodeCoverage.
xunit.v3 => mono.cecil 0.11.6
Microsoft.Testing.Extensions.CodeCoverage => 0.11.5

Adding <PackageReference Include="Mono.Cecil" Version="0.11.6" /> in your project should fix the issue.

[bradwilson]

This issue should be re-opened.

To be clear, adding the package reference is a workaround, not a fix. Microsoft.Testing.Extensions.CodeCoverage should be shipped with a NuGet package reference, not with DLLs buried into the package, or else the automatic binding redirect system will fail.

[bradwilson]

@fhnaseer

[Youssef1313]

@fhnaseer Please revisit this. We want to play as nice as possible with the rest of the ecosystem and avoid historical VSTest stuff as much as we can. The package should declare Mono.Cecil as a dependency instead of shipping the dlls.

[fhnaseer]

@bradwilson @Youssef1313 Microsoft.Testing.Extensions.CodeCoverage uses a wrapper Microsoft.Dotnet.Cecil to support some additional scenarios which are not available in the publicly available Mono.Cecil. Since Microsoft.Dotnet.Cecil is not available on nuget.org, we ship dlls with the package.

[Youssef1313]

@fhnaseer Why not use a different assembly name then? That would make much better sense to me.

[fhnaseer]

It's a fork. It is designed in such a way that it can replace original public mono.cecil dlls. Also, we (code coverage) do not control the behavior.