-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MKDocs integration #607
MKDocs integration #607
Conversation
# Conflicts: # docs/developer-experience/devcontainers/readme.md
Looks great!!! |
Looking at the link checking errors these are the ones failing: FILE: ./CONTRIBUTING.md 16 links checked. ERROR: 3 dead links found! FILE: ./README.md 21 links checked. ERROR: 3 dead links found! |
We can say that the following can come after the first version of this PR is merged in:
|
@fnocera I'm working on the linting issues. |
# Conflicts: # docs/observability/best-practices.md # docs/observability/observability-as-code.md # docs/observability/observability-pipelines.md # docs/observability/recipes-observability.md
@fnocera @TessFerrandez all lint errors are fixed and the GH Action was tested on my fork. PR is ready for review and merge. Demo (https://omri374.github.io/code-with-engineering-playbook/) was re-created last week. |
@brockneedscoffee flagging for your review as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved - pending review that the new documentation section is merged in/added to the PR.
Thanks so much for this huge contribution @omri374, this will make the playbook look and feel so much more user friendly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved - pending review that the new documentation section is merged in/added to the PR.
Thanks so much for this huge contribution @omri374, this will make the playbook look and feel so much more user friendly.
MKDocs integration
What are you trying to address
Creating a static website for the playbook based on mkdocs and mkdocs-material.
Demo can be found here: https://omri374.github.io/code-with-engineering-playbook/
To test locally
pip install -r requirements-docs.txt
)mkdocs serve
Description of new changes
docs
folder.mkdocs.yml
which specifies the mkdocs behavior.requirements-docs.txt
file with the required dependencies for generating the docs.Still missing
requirements-docs.txt
Relevant issue: #549
For all pull requests