Add deployment: allow specifying deployment key #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
grav
force-pushed
the
grav/specify-deployment-key
branch
from
3b598c7 to
7b27e94
Compare
|
+1 |
|
@grav Thank you for your contribution! I’ve tested your changes, and they work as expected. Could you please update the documentation and the command description to reflect the newly added argument? |
|
@DmitriyKirakosyan Thanks for the feedback. I've added example usage to the CLI configuration and the README. |
grav
force-pushed
the
grav/specify-deployment-key
branch
from
30c7270 to
dea9ba7
Compare
lucen-ms
approved these changes
Jan 6, 2025
|
Thank you @grav for your contribution. |
ashirman
added a commit
to revopush/code-push-server
that referenced
this pull request
Jan 13, 2025
Add deployment: allow specifying deployment key (microsoft#60)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When migrating an existing app to the stand-alone server, it makes sense to re-use existing deployment keys.
The Rest API already allows for explicitly specifying deployment key, so this PR just adds an optional argument to the
deployment addcommand.Example usage: