-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Azure Data Factory module #397
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fantastic! A few minor changes, but nothing major. Thanks for the contribution and apologies for the delay.
infra/modules/providers/azure/data-factory/tests/integration/data_factory_integration_test.go
Show resolved
Hide resolved
Thank you @helayoty. We have a couple of other customers that have also asked for ADF Cobalt support. Much appreciated |
c7a1761
to
5d387e7
Compare
infra/modules/providers/azure/data-factory/tests/unit/data_factory_unit_test.go
Outdated
Show resolved
Hide resolved
7b1fdcf
to
a16a06c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@helayoty - 2 minor comments related to formatting. I won't block on these, but they will be easy to fix.
All Submissions:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Support Azure Data factory with the following features:
Does this introduce a breaking change?
Any relevant logs, error output, etc?
(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)
Other information
Cc: @nmiodice