Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Azure Data Factory module #397

Merged
merged 5 commits into from
Jul 31, 2020

Conversation

helayoty
Copy link
Contributor

All Submissions:


  • [YES] Have you followed the guidelines in our Contributing document?
  • [YES] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [YES] I have updated the documentation accordingly.
  • [YES] I have added tests to cover my changes.
  • [YES] All new and existing tests passed.
  • [YES] My code follows the code style of this project.
  • [YES] I ran lint checks locally prior to submission.
  • [YES] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

What is the current behavior?


Issue Number: N/A

What is the new behavior?


Support Azure Data factory with the following features:

  • Ability to provision a single Data Factory instance
  • Ability to provision a configurable Pipeline
  • Ability to configure Trigger
  • Ability to configure SQL server Dataset
  • Ability to configure SQL server Linked Service

Does this introduce a breaking change?


  • [NO]

Any relevant logs, error output, etc?


(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Other information


Cc: @nmiodice

@helayoty helayoty requested a review from erikschlegel as a code owner July 21, 2020 01:24
Copy link

@nmiodice nmiodice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fantastic! A few minor changes, but nothing major. Thanks for the contribution and apologies for the delay.

@erikschlegel
Copy link
Contributor

Thank you @helayoty. We have a couple of other customers that have also asked for ADF Cobalt support.

Much appreciated

@helayoty helayoty force-pushed the helayoty/add-adf-module branch from c7a1761 to 5d387e7 Compare July 29, 2020 23:01
@helayoty helayoty requested a review from nmiodice July 29, 2020 23:20
@helayoty helayoty force-pushed the helayoty/add-adf-module branch from 7b1fdcf to a16a06c Compare July 30, 2020 00:05
Copy link

@nmiodice nmiodice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@helayoty - 2 minor comments related to formatting. I won't block on these, but they will be easy to fix.

@helayoty helayoty requested a review from nmiodice July 30, 2020 16:06
@nmiodice nmiodice merged commit 5a6debf into microsoft:master Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants