Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable white-listing features & tests and self-hosted agents #350

Merged
merged 25 commits into from
Oct 7, 2019
Merged

Enable white-listing features & tests and self-hosted agents #350

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
15a577e
Edits to support whitelisting self-hosted build agents.
Sep 27, 2019
dfae41d
Merge remote-tracking branch 'origin/master' into feature/242
Sep 27, 2019
bb688c8
Updating unit test counts
Sep 27, 2019
b205089
updating lint error
tasdevani21 Sep 27, 2019
02bd6b2
updating unit tests
tasdevani21 Sep 27, 2019
0e5c414
removing dynamic name key
tasdevani21 Sep 27, 2019
f9c039d
formatting
Oct 1, 2019
8dd76c7
formatting
Oct 1, 2019
2234039
remove workstream-specific prefixes
Oct 1, 2019
3f3c5fd
Merge remote-tracking branch 'remotes/origin/master' into feature/242
Oct 1, 2019
902f565
update test expectation
Oct 1, 2019
8ebcf77
removed out-modded tests
Oct 1, 2019
8f03199
removed un-needed integration tests
Oct 1, 2019
1dcca29
Merge remote-tracking branch 'origin/master' into feature/242
Oct 3, 2019
4d8b116
update test resource count
Oct 3, 2019
96c99e6
disable webhook int testing
Oct 4, 2019
ae38702
remove source code providing a default for `resource_ip_whitelist`
Oct 4, 2019
b1adedc
remove source code providing a default for `resource_ip_whitelist`
Oct 4, 2019
6d279dd
remove source code providing a default for `resource_ip_whitelist`
Oct 4, 2019
6347ed9
update unit_test to match expectations
Oct 4, 2019
f95a43a
force TF CLI to gen errors for missing-but-required vars
Oct 4, 2019
e4cbb0c
ensure certain new env vars are exported
Oct 4, 2019
da3e776
update int test
Oct 4, 2019
f49b8d5
remove dead code
Oct 7, 2019
8bda174
the list of IPs for unit tesings are misleading (these particular val…
Oct 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove dead code
  • Loading branch information
Stephen Henderson committed Oct 7, 2019
commit f49b8d52af492db2b512f7273b9efbd4650769ae
1 change: 0 additions & 1 deletion infra/templates/az-isolated-service-single-region/terraform.tfvars
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ unauthn_deployment_targets = [

# Note: this is configured as such only to test IP Whitelists. This is a well
# known DNS address
# resource_ip_whitelist = ["0.0.0.0/8"]
ase_name = "co-static-ase"
ase_resource_group = "co-static-ase-rg"
ase_vnet_name = "co-static-ase-vnet"
2 changes: 0 additions & 2 deletions infra/templates/az-isolated-service-single-region/tests/integration/integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,6 @@ func TestIsoSingleRegion(t *testing.T) {
TfOptions: tfOptions,
ExpectedTfOutputCount: 10,
TfOutputAssertions: []infratests.TerraformOutputValidation{
// verifyCDHooksConfiguredProperly,
// verifyCorrectWebhookEndpointForApps,
verifyCorrectDeploymentTargetForApps,
},
}
Expand Down