Add Azure Monitoring Module to enable default alert criteria and notifications#132
Merged
Merged
Conversation
TechnicallyWilliams
changed the title
TechnicallyWilliams
changed the title
TechnicallyWilliams
requested review from
erikschlegel,
hxlnt,
ianphil and
nmiodice
nmiodice
reviewed
May 24, 2019
nmiodice
left a comment
nmiodice
left a comment
There was a problem hiding this comment.
Looks great! A few nits/comments and questions but overall it looks awesome.
erikschlegel
requested changes
May 28, 2019
erikschlegel
left a comment
erikschlegel
left a comment
Contributor
There was a problem hiding this comment.
This is looking great @TechnicallyWilliams . Nice work. Just left some minor nits below.
added app monitoring readme; updated variable names Added and integrated app monitoring into azure simple template
update readme Update Readme.md Update README.md Update README.md Redesigned README.md provide clarity regarding resourceIds and scaling dimensions update README; remove comments Update README.md and azure simple variables added attributes section to README.md
TechnicallyWilliams
force-pushed
the
dexterw/features/app-monitoring
branch
from
3f14349 to
42b7b97
Compare
erikschlegel
approved these changes
May 30, 2019
erikschlegel
left a comment
erikschlegel
left a comment
Contributor
There was a problem hiding this comment.
Woot! Great work @TechnicallyWilliams. Happy to see this flexible solution to add monitoring to a fleet of app service containers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
What is the current behavior?
Issue Number: #86
Fixes #86
What is the new behavior?
The new module introduced in this PR deploys the Azure Monitor Service. It is a custom Terraform module called App-Monitoring that Cobalt Templates can use in order to assign configurable metric alert criteria to individual Azure Resources for monitoring.
In addition to the metric alert criteria, this module introduces configurable action groups that when paired with metric alert criteria can trigger event types like e-mail notifications.
In conclusion, the App-Monitoring module is now being referenced by the Azure Simple Template which now adds the following default behavior to the template:
Does this introduce a breaking change?
Any relevant logs, error output, etc?
Other information
Mapping metric alert criteria to a resource:
