Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing hinting on Braces #596

Merged
merged 6 commits into from
Nov 1, 2021
Merged

Fixing hinting on Braces #596

merged 6 commits into from
Nov 1, 2021

Conversation

aaronbell
Copy link
Collaborator

Summary of the Pull Request

When I updated the brace character, it appeared that the italic versions were rendering correctly. However, that was incorrect...

They are rendering correctly now.

PR Checklist

aaronbell and others added 6 commits November 1, 2021 09:20
1) Re-implements the CALT issue wherein LIG GSUB wouldn't work (this was lost during the fix.

2) Changes the STAT table generation library from statmake to gftools.stat, and all other necessary fixes.
removing "Medium" weight.
This update is primarily a bugfix update with improvements to Arabic as well as a variety of other small bugs / requests from the community.

Another additional change is coming.
Correcting hinting on italic brace characters and ligatures
@aaronbell
Copy link
Collaborator Author

Rebased so there's just the one change fixing the hinting

@DHowett
Copy link
Member

DHowett commented Nov 1, 2021

Oof.

Point order change?

@DHowett
Copy link
Member

DHowett commented Nov 1, 2021

Looks like the Oct 31 release was too spooky. :)

@aaronbell
Copy link
Collaborator Author

Yup. I checked in VTT, but it didn't show the issue initially, so I thought that the point orders were OK. Turns out not!

@DHowett DHowett merged commit 2c0cea5 into microsoft:main Nov 1, 2021
@DHowett
Copy link
Member

DHowett commented Nov 1, 2021

Thanks for the fix!

@aaronbell
Copy link
Collaborator Author

Thanks! Sorry for the trouble

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Braces & their ligature variants not rendering properly in VS Code #{ }# {| |} { }
2 participants