Skip to content

Conversation

@joseartrivera
Copy link
Contributor

Part of #338

Description of the changes:

  • Allow swapping the color pallet to a different set of colors when in high contrast mode, automatically updating the equation colors on the graph
  • Fixes an equation not getting a color assigned if the EquationTextBox was already loaded previously
  • Keep a single reference to available colors instead of creating multiple copies

How changes were validated:

  • Manual tests

@joseartrivera joseartrivera added the graphing calculator Work items related to the graphing calculator feature. label Nov 5, 2019
@joseartrivera joseartrivera requested a review from sanderl November 5, 2019 22:12
<SolidColorBrush x:Key="EquationBrush14" Color="#FF018574"/>
<SolidColorBrush x:Key="EquationBrush15" Color="#FF10893E"/>
<SolidColorBrush x:Key="EquationBrush16" Color="#FF000000"/>
<!-- TODO: Figure out what colors we can use in high contrast -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you still need this todo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I just randomly picked these for now. Some of them don't work too well because currently the graph is always white. Unclear what the plan is for that in high contrast.

@joseartrivera joseartrivera merged commit 433d54d into microsoft:feature/GraphingCalculator Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

graphing calculator Work items related to the graphing calculator feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants