Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up unit test projects #4

Merged
merged 3 commits into from
Jan 30, 2019
Merged

Clean up unit test projects #4

merged 3 commits into from
Jan 30, 2019

Conversation

mcooley
Copy link
Member

@mcooley mcooley commented Jan 30, 2019

During our preparation for the move to GitHub we created duplicate unit test projects. We no longer need the one in internal/, so let's delete it and remove the "_VS" suffix from the public unit test project.

Also adding a missing self-signed certificate which is needed to get the UnitTests project to build outside of visual studio, and corrected our .gitignore directives to include this file.

@mcooley mcooley merged commit 1c7187f into microsoft:master Jan 30, 2019
@mcooley mcooley mentioned this pull request Jan 31, 2019
Merged
@danilotg danilotg mentioned this pull request May 31, 2019
Closed
@HowardWolosky HowardWolosky added codebase quality Issues that are not bugs, but still might be worth improving (eg, code hygiene or maintainability) build Any work that primarily impacts the solution / project files, but not the code itself. tooling Work that primarily impacts the yaml or administration of the GitHub project itself. and removed codebase quality Issues that are not bugs, but still might be worth improving (eg, code hygiene or maintainability) build Any work that primarily impacts the solution / project files, but not the code itself. labels Jun 10, 2019
Chips1234 added a commit to Chips1234/calculator that referenced this pull request Mar 6, 2021
@Chips1234
Cleanup microsoft#4
029fa14
@ankurtri ankurtri mentioned this pull request Jul 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwaldbaum bwaldbaum bwaldbaum approved these changes

Assignees
No one assigned
Labels
build Any work that primarily impacts the solution / project files, but not the code itself. tooling Work that primarily impacts the yaml or administration of the GitHub project itself.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcooley @bwaldbaum @HowardWolosky