Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark classes as final where applicable #189

Merged
merged 2 commits into from
Mar 8, 2019
Merged

Mark classes as final where applicable #189

merged 2 commits into from
Mar 8, 2019

Conversation

janisozaur
Copy link
Contributor

I checked and there should be no conflict with #188

@danbelcher-MSFT
Copy link

I'm fine with this change, but I noticed that this improvement is limited only to pure C++ classes. For C++/CX, there is the equivalent sealed keyword and, if we think classes should be final/sealed where possible, then we should also seal the CX classes.

@danbelcher-MSFT danbelcher-MSFT mentioned this pull request Mar 8, 2019
Merged
@danbelcher-MSFT danbelcher-MSFT merged commit e2c7db6 into microsoft:master Mar 8, 2019
@janisozaur janisozaur deleted the final branch January 12, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danbelcher-MSFT danbelcher-MSFT danbelcher-MSFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janisozaur @danbelcher-MSFT