Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Space and Enter KeyDown event for About button #1459

Merged
merged 1 commit into from
Jan 11, 2021
Merged

Handle Space and Enter KeyDown event for About button #1459

merged 1 commit into from
Jan 11, 2021

Conversation

xuhongxu96
Copy link
Contributor

@xuhongxu96 xuhongxu96 commented Jan 7, 2021 •
edited by grochocki
Loading

Fixes #1461: ‘About’ menu item is not getting activated via keyboard using Enter or Space key

Description of the changes:

  • Add OnKeyDown event handler to open about flyout when clicking Enter or Space with AboutButton selected

How changes were validated:

Specify how you tested your changes (i.e. manual/ad-hoc testing, automated testing, new automated tests added)-->

  • Manually tested

joseartrivera
joseartrivera approved these changes Jan 11, 2021
View reviewed changes
Copy link
Contributor

@joseartrivera joseartrivera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix! It works great :)

@joseartrivera joseartrivera merged commit f910d64 into microsoft:master Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joseartrivera joseartrivera joseartrivera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

‘About’ menu item is not getting activated via keyboard using Enter or Space key
2 participants
@xuhongxu96 @joseartrivera