Add link to GitHub repo on about flyout #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grochocki
reviewed
Dec 7, 2020
greedyAI
reviewed
Dec 10, 2020
| @@ -28,6 +28,7 @@ | |||
| <Style x:Key="AboutFlyoutPresenterStyle" TargetType="FlyoutPresenter"> | |||
| <Setter Property="IsTabStop" Value="False"/> | |||
| <Setter Property="AutomationProperties.AccessibilityView" Value="Raw"/> | |||
| <Setter Property="ScrollViewer.HorizontalScrollBarVisibility" Value="Disabled"/> | |||
There was a problem hiding this comment.
Why is this necessary? There is no ScrollViewer in the AboutFlyout.
There was a problem hiding this comment.
The default control template of FlyoutPresenter contains a ScrollViewer.
This is what it looks like if the ScrollViewer property setter is removed:
There was a problem hiding this comment.
Ah, ok. That makes sense. Good work!
greedyAI
previously approved these changes
Dec 10, 2020
joseartrivera
previously approved these changes
Dec 10, 2020
grochocki
reviewed
Dec 11, 2020
chaitanyamehta
dismissed stale reviews from joseartrivera and greedyAI
via
284a437
grochocki
approved these changes
Dec 11, 2020
|
Perfect! Thanks again, @chaitanyamehta. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #582
Display link to the GitHub repo on the about flyout. Implementation is similar to link shown in currency converter mode when application is offline. (Offline. Please check your%HL%Network Settings%HL%)
Description of the changes:
How changes were validated: