Use different formatter for different currency #1432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bd8aab3.
joseartrivera
requested changes
Nov 17, 2020
ghost
added
Disable decimal input if maxFractionDigits is 0 Fix input may be blocked after switched active
xuhongxu96
commented
Nov 19, 2020
xuhongxu96
commented
Nov 19, 2020
Reset currency before tests Fix: input is blocked after switching to currency with less fractional digits
xuhongxu96
commented
Nov 24, 2020
joseartrivera
requested changes
Nov 25, 2020
To fix incorrect result after switching currency with less fractional digits
xuhongxu96
commented
Nov 26, 2020
joseartrivera
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #424 , #1204 , #1438 .
Before, the Calculator will use
CurrencyFormatterper system locale for all currencies.So, users cannot input
USDwith fraction digits in Japanese locale, becauseJPYdoesn't allow fraction digits.Description of the changes:
m_currencyFormatter1,m_currencyFormatter2How changes were validated:
Functional UI tests(it does not work because there is no full currency list in CI)TestCurrencyFormattingLogicforUnitConverterViewModel