Lock m_renderMain in Grapher::TryInitializeGraph to avoid race condition #1430
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1293 .
The Calculator crashes when removing an expression with another expression just cleared.
This behavior will trigger the graph updating twice in a short time, which leads to a potential race condition to
m_graph
.The app crashes because one thread is rendering the
m_graph
and another tries to initialize them_graph
.Description of the changes:
m_renderMain->GetCriticalSection()
inGrapher::TryInitializeGraph
How changes were validated: