Skip to content

Enable code analysis on all projects and resolve warnings #693

Open

Description

Visual Studio's code analysis tools can help find issues in our C++ code. Eventually, it would be great to have these tools running in all of our builds and to fix all the warnings they generate.

See #689 for an example of how to enable the tools during the build. We'll enable code analysis only in the "Release" configuration to avoid slowing down Debug builds.

To see which warnings still need to be fixed, check a recent build from the master branch.

It would be best to submit fixes for unrelated warnings as separate PRs. I'll close out this issue when 1) all C++ projects are building with code analysis rules on and 2) all the warnings generated by those tools are fixed or silenced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    Pri: 2approvedbuildAny work that primarily impacts the solution / project files, but not the code itself.codebase qualityIssues that are not bugs, but still might be worth improving (eg, code hygiene or maintainability)help wantedIssues identified as good community contribution opportunities

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions