Catch polymorphic types by const-ref

microsoft · Mar 6, 2019 · 71436e1 · 71436e1
1 parent 1eb717f
commit 71436e1
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/CalcManager/CalculatorVector.h b/src/CalcManager/CalculatorVector.h
@@ -14,7 +14,7 @@ class CalculatorVector
         {
             *item = m_vector.at(index);
         }
-        catch (std::out_of_range /*ex*/)
+        catch (const std::out_of_range& /*ex*/)
         {
             hr = E_BOUNDS;
         }
@@ -34,7 +34,7 @@ class CalculatorVector
         {
             m_vector[index] = item;
         }
-        catch (std::out_of_range /*ex*/)
+        catch (const std::out_of_range& /*ex*/)
         {
             hr = E_BOUNDS;
         }
@@ -63,7 +63,7 @@ class CalculatorVector
             auto iter = m_vector.begin() + index;
             m_vector.insert(iter, item);
         }
-        catch (std::bad_alloc /*ex*/)
+        catch (const std::bad_alloc& /*ex*/)
         {
             hr = E_OUTOFMEMORY;
         }
@@ -92,7 +92,7 @@ class CalculatorVector
         {
             m_vector.push_back(item);
         }
-        catch (std::bad_alloc /*ex*/)
+        catch (const std::bad_alloc& /*ex*/)
         {
             hr = E_OUTOFMEMORY;
         }