Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the misuse of json.dumps() #71

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cococ0j
Copy link

@cococ0j cococ0j commented Jul 14, 2020

Correct the mistake where json.dumps() is used to convert dict to json object.
Usually json.dumps() is used to convert JSON objects to Python String objects.
So I purpose to use json.loads() here.

Correct the mistake which uses json.dumps() to convert dict to json object.
I correct all json.dumps() to json.loads() where the comment is saying "Convert dictionary to JSON object". Because usually json.dumps() is used to converting JSON objects to Python String objects.
@ghost
Copy link

ghost commented Jul 14, 2020

CLA assistant check
All CLA requirements met.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant