This repository was archived by the owner on Jan 15, 2025. It is now read-only.
Fix : Add region support for lg:translate command#995
Merged
Conversation
Danieladu
approved these changes
Sep 29, 2020
cosmicshuai
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the change of Azure Text Translate API (API Ref).
Now it requires a Ocp-Apim-Subscription-Region in the headers.
In this PR, a new flag "region" is added. The value of region is the location in the azure keys and endpoints page, see the picture below
Now the command should be called like:
bf lg:translate -i inputFile --srclang=src-lang --tgtlang=tgt-lang --translatekey=subscription-key --region=subscription-region