Skip to content
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

Comments

Make LU parser behavior configurable#992

Merged
boydc2014 merged 11 commits intomainfrom
hond/lu_configurable
Sep 30, 2020
Merged

Make LU parser behavior configurable#992
boydc2014 merged 11 commits intomainfrom
hond/lu_configurable

Conversation

@Danieladu
Copy link
Contributor

@Danieladu Danieladu commented Sep 28, 2020 •
edited by boydc2014
Loading

Fixes: #974

Configurations:

  • enablePattern
  • enableMLEntities
  • enableListEntities
  • enableCompositeEntities
  • enablePrebuiltEntities
  • enableRegexEntities
  • enablePhraseLists
  • enableModelDescription
  • enableExternalReferences
  • enableFeatures
  • enableComments (default support)

@feich-ms
Copy link
Contributor

feich-ms commented Sep 28, 2020 •
edited
Loading

Looks good to me except some minor comments

@feich-ms
Copy link
Contributor

feich-ms commented Sep 28, 2020 

                            }

add a check here. Here means this entity will be added as normal ml entity I think.

Refers to: packages/lu/src/parser/lufile/parseFileContents.js:955 in 0ffb223. [](commit_id = 0ffb223, deletion_comment = False)

@Danieladu Danieladu marked this pull request as ready for review September 28, 2020 07:12
@boydc2014 boydc2014 merged commit 845f2e1 into main Sep 30, 2020
@boydc2014 boydc2014 deleted the hond/lu_configurable branch September 30, 2020 01:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@munozemilio munozemilio Awaiting requested review from munozemilio

2 more reviewers

@feich-ms feich-ms feich-ms left review comments

@boydc2014 boydc2014 boydc2014 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make LU parser behavior configurable

3 participants

@Danieladu @feich-ms @boydc2014