This repository was archived by the owner on Jan 15, 2025. It is now read-only.
add version in luis recognizer and settings file and adjust deleteOldVersion interface#962
Merged
add version in luis recognizer and settings file and adjust deleteOldVersion interface#962
Conversation
boydc2014
reviewed
Sep 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per requirememts of version control, add version property in luis recognizer and settings file to enable version control. And also adjust deleteOldVersion to keepVersions in luis builder interface. The keepVersions parameter is number of kept luis application versions when updating. Composer can set it to a reasonable value(such as 5 or 10 or even 100) when consuming this keepVersions interface. For luis build CLI, no interface changes. If the deleteOldVersion is set true, that means keeping only one latest version and delete all other versions, if deleteOldVersion is not set or set to false, the luis build will keep all versons up to 100(LUIS limit).