Skip to content
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

Comments

bf-lu: support new link reference format#961

Merged
feich-ms merged 4 commits intomainfrom
feich/supportLinkReference
Sep 4, 2020
Merged

bf-lu: support new link reference format#961
feich-ms merged 4 commits intomainfrom
feich/supportLinkReference

Conversation

@feich-ms
Copy link
Contributor

@feich-ms feich-ms commented Sep 2, 2020

fix #917 to support new import format in lu file like

[import][1]

# intent 1
- [reference][2]

[1]:foo.lu
[2]:bar.lu#intent2

@feich-ms feich-ms requested a review from vishwacsena September 2, 2020 10:08
@feich-ms feich-ms changed the title Feich/support link reference bf-lu: support new link reference format Sep 2, 2020
@feich-ms feich-ms requested a review from boydc2014 September 2, 2020 10:08
Copy link
Contributor

@vishwacsena vishwacsena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add negative tests to verify intended behavior for

  • invalid syntax (e.g. [foo[1]] or missing closing parenthesis etc)
  • unable to resolve reference

Can you also add a test to verify that the reference can be to a URL?

[foo][1]
[1]: https://blobstore.azurewebsites.net/1.lu#myTrigger

@feich-ms
Copy link
Contributor Author

feich-ms commented Sep 3, 2020

@vishwacsena

  1. negetive tests are added in this commit 957395a. For invalid import syntax in utterances, it's not easy to validate since utterance can tolerate all kinds of inputs and we can't distinguish it's invalid import or just utterance itself, so I didn't add tests for utterance import syntax error(Tests for invalid reference file or URL in utterance are added).
  2. test to verify URL reference is added in this commit 58d7be3

@feich-ms feich-ms merged commit ed789e7 into main Sep 4, 2020
@feich-ms feich-ms deleted the feich/supportLinkReference branch September 4, 2020 02:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LU format link reference additions

2 participants