Skip to content
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

Comments

fix lu parser to accept quotes and interchanageable label in pharselist definition#915

Merged
boydc2014 merged 3 commits intomasterfrom
feich/fixLuParserGrammar
Jul 31, 2020
Merged

fix lu parser to accept quotes and interchanageable label in pharselist definition#915
boydc2014 merged 3 commits intomasterfrom
feich/fixLuParserGrammar

Conversation

@feich-ms
Copy link
Contributor

@feich-ms feich-ms commented Jul 29, 2020

fix #900.
Before the fix, phraselist with quotes and interchangeable label like below will not be parsed correctly

@ intent Application usesFeature "Application Synonyms"
@ phraselist "Application Synonyms"(interchangeable) disabledForAllModels = 
	- Application,Web pages,Sites

After the fix, it can be parsed and converted to luis json correctly. It can also parse other labels besides interchangeable if we need.

@feich-ms feich-ms requested a review from munozemilio as a code owner July 29, 2020 10:08
@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2020

Codecov Report

Merging #915 into master will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #915      +/-   ##
==========================================
+ Coverage   56.58%   56.67%   +0.08%     
==========================================
  Files         219      219              
  Lines       16760    16686      -74     
  Branches     2335     2328       -7     
==========================================
- Hits         9484     9457      -27     
+ Misses       6692     6651      -41     
+ Partials      584      578       -6     
Impacted Files Coverage Δ
packages/lu/src/parser/lufile/parseFileContents.js 81.67% <100.00%> (-0.06%) ⬇️
...mathematics/confusion_matrix/AppConfusionMatrix.ts 6.66% <0.00%> (-22.32%) ⬇️
packages/cli/src/hooks/init/inithook.ts 62.26% <0.00%> (-0.78%) ⬇️
packages/config/src/commands/config/set.ts 100.00% <0.00%> (ø)
packages/config/src/utils/configfilehandler.ts 100.00% <0.00%> (ø)
packages/config/src/commands/config/set/luis.ts 100.00% <0.00%> (ø)
packages/config/src/commands/config/show/luis.ts 100.00% <0.00%> (ø)
...ackages/config/src/commands/config/set/qnamaker.ts 100.00% <0.00%> (ø)
...ckages/config/src/commands/config/set/telemetry.ts 100.00% <0.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3786d10...631e4d3. Read the comment docs.

@feich-ms feich-ms changed the title fix lu parser to accept quotes and interchanageable combination in pharselist entity definition fix lu parser to accept quotes and interchanageable combination in pharselist definition Jul 29, 2020
@feich-ms feich-ms changed the title fix lu parser to accept quotes and interchanageable combination in pharselist definition fix lu parser to accept quotes and interchanageable label in pharselist definition Jul 29, 2020
@boydc2014 boydc2014 merged commit 4aa848c into master Jul 31, 2020
@feich-ms feich-ms deleted the feich/fixLuParserGrammar branch October 13, 2020 02:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update_cognitive_models.ps1 misbehave when Machine learning features are added

3 participants