This repository was archived by the owner on Jan 15, 2025. It is now read-only.
fix lu parser to accept quotes and interchanageable label in pharselist definition#915
Merged
fix lu parser to accept quotes and interchanageable label in pharselist definition#915
Conversation
Codecov Report
@@ Coverage Diff @@
## master #915 +/- ##
==========================================
+ Coverage 56.58% 56.67% +0.08%
==========================================
Files 219 219
Lines 16760 16686 -74
Branches 2335 2328 -7
==========================================
- Hits 9484 9457 -27
+ Misses 6692 6651 -41
+ Partials 584 578 -6
Continue to review full report at Codecov.
|
boydc2014
reviewed
Jul 29, 2020
boydc2014
approved these changes
Jul 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #900.
Before the fix, phraselist with quotes and interchangeable label like below will not be parsed correctly
After the fix, it can be parsed and converted to luis json correctly. It can also parse other labels besides
interchangeableif we need.