Skip to content
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

Comments

Remove deprecated module: "request" from cli#913

Merged
munozemilio merged 3 commits intomasterfrom
emimunoz/remove-request
Jul 29, 2020
Merged

Remove deprecated module: "request" from cli#913
munozemilio merged 3 commits intomasterfrom
emimunoz/remove-request

Conversation

@munozemilio
Copy link
Contributor

@munozemilio munozemilio commented Jul 27, 2020

Fixes #749
Since "request" is now deprecated this PR replaces it with node fetch.

@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2020

Codecov Report

Merging #913 into master will decrease coverage by 4.49%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #913      +/-   ##
==========================================
- Coverage   60.34%   55.84%   -4.50%     
==========================================
  Files         220      219       -1     
  Lines       18582    16377    -2205     
  Branches     2452     2335     -117     
==========================================
- Hits        11213     9146    -2067     
+ Misses       6776     6642     -134     
+ Partials      593      589       -4     
Impacted Files Coverage Δ
packages/command/src/readpipeddata.ts 65.21% <0.00%> (-18.12%) ⬇️
packages/config/src/commands/config/index.ts 60.00% <0.00%> (-15.00%) ⬇️
...kages/luis/src/commands/luis/application/create.ts 60.00% <0.00%> (-13.34%) ⬇️
packages/lg/src/commands/lg/index.ts 66.66% <0.00%> (-11.12%) ⬇️
...ages/lu/src/parser/qna/alterations/qnaConverter.js 40.00% <0.00%> (-10.00%) ⬇️
packages/luis/src/commands/luis/version/import.ts 75.00% <0.00%> (-9.79%) ⬇️
...maker/src/commands/qnamaker/alterations/replace.ts 73.68% <0.00%> (-9.65%) ⬇️
packages/luis/src/commands/luis/cross-train.ts 77.27% <0.00%> (-9.62%) ⬇️
...ages/qnamaker/src/commands/qnamaker/cross-train.ts 77.27% <0.00%> (-9.62%) ⬇️
...ckages/qnamaker/src/commands/qnamaker/kb/delete.ts 86.95% <0.00%> (-9.48%) ⬇️
... and 117 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ac1279...76274e8. Read the comment docs.

@munozemilio munozemilio merged commit 52d4917 into master Jul 29, 2020
@munozemilio munozemilio deleted the emimunoz/remove-request branch July 29, 2020 17:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BF CLI reports that request has been deprecated during installation.

3 participants