Skip to content
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

Comments

Build yaml files refactor#911

Merged
munozemilio merged 46 commits intomasterfrom
emimunoz/build-files-refactor
Jul 29, 2020
Merged

Build yaml files refactor#911
munozemilio merged 46 commits intomasterfrom
emimunoz/build-files-refactor

Conversation

@munozemilio
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2020

Codecov Report

Merging #911 into master will decrease coverage by 4.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #911      +/-   ##
==========================================
- Coverage   59.95%   55.82%   -4.14%     
==========================================
  Files         220      220              
  Lines       18450    16252    -2198     
  Branches     2416     2327      -89     
==========================================
- Hits        11062     9072    -1990     
+ Misses       6797     6597     -200     
+ Partials      591      583       -8     
Impacted Files Coverage Δ
...mathematics/confusion_matrix/AppConfusionMatrix.ts 6.66% <0.00%> (-18.92%) ⬇️
packages/command/src/readpipeddata.ts 65.21% <0.00%> (-18.12%) ⬇️
packages/plugins/src/commands/plugins/install.ts 34.48% <0.00%> (-16.50%) ⬇️
...kages/luis/src/commands/luis/application/create.ts 60.00% <0.00%> (-13.34%) ⬇️
...ages/lu/src/parser/qna/alterations/qnaConverter.js 40.00% <0.00%> (-10.00%) ⬇️
packages/luis/src/commands/luis/version/import.ts 75.00% <0.00%> (-9.79%) ⬇️
packages/luis/src/commands/luis/cross-train.ts 77.27% <0.00%> (-9.62%) ⬇️
packages/lu/src/utils/textfilereader.ts 44.00% <0.00%> (-9.13%) ⬇️
packages/luis/src/commands/luis/train/run.ts 66.66% <0.00%> (-8.75%) ⬇️
packages/command/src/clierror.ts 66.66% <0.00%> (-8.34%) ⬇️
... and 85 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 930f45e...57a0df3. Read the comment docs.

@munozemilio
Copy link
Contributor Author

FIxes #861

@munozemilio munozemilio requested a review from BruceHaley July 28, 2020 22:20
@@ -0,0 +1,73 @@
steps:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if this template file was named with "-steps" at the end. That lets us more easily distinguish between root yaml files and template yaml files. That is the standard we are using elsewhere. For example: https://github.com/microsoft/botbuilder-dotnet/blob/master/build/yaml/ci-build-steps.yml

@munozemilio munozemilio merged commit 4ac1279 into master Jul 29, 2020
@munozemilio munozemilio deleted the emimunoz/build-files-refactor branch July 29, 2020 01:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants