Skip to content
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

Comments

Handle locale in .uischema.#909

Merged
cleemullins merged 4 commits intomasterfrom
chrimc/schema
Jul 29, 2020
Merged

Handle locale in .uischema.#909
cleemullins merged 4 commits intomasterfrom
chrimc/schema

Conversation

@chrimc62
Copy link

Kind names and locale are ambiguous, so check in merged .schema to resolve.
Add check for missing $schema.

Add check for missing $schema.
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2020

Codecov Report

Merging #909 into master will increase coverage by 0.86%.
The diff coverage is 84.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #909      +/-   ##
==========================================
+ Coverage   55.64%   56.51%   +0.86%     
==========================================
  Files         220      220              
  Lines       16179    16582     +403     
  Branches     2308     2309       +1     
==========================================
+ Hits         9003     9371     +368     
- Misses       6608     6645      +37     
+ Partials      568      566       -2     
Impacted Files Coverage Δ
packages/dialog/src/commands/dialog/merge.ts 0.00% <0.00%> (ø)
packages/dialog/src/library/schemaMerger.ts 79.29% <85.71%> (-0.11%) ⬇️
...mathematics/confusion_matrix/AppConfusionMatrix.ts 6.66% <0.00%> (-22.32%) ⬇️
packages/lu/src/utils/textfilereader.ts 28.57% <0.00%> (-15.43%) ⬇️
packages/lu/src/parser/lu/lu.js 91.66% <0.00%> (-8.34%) ⬇️
packages/lu/src/parser/lu/qna.js 83.33% <0.00%> (-6.67%) ⬇️
packages/lu/src/parser/lufile/newEntitySection.js 92.45% <0.00%> (-3.11%) ⬇️
packages/lu/src/parser/cross-train/crossTrainer.js 92.43% <0.00%> (-2.78%) ⬇️
packages/lu/src/parser/qna/qnamaker/kbCollate.js 90.65% <0.00%> (-2.35%) ⬇️
packages/lu/src/parser/lu/luMerger.js 76.34% <0.00%> (-1.40%) ⬇️
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52d4917...f179195. Read the comment docs.

Chris McConnell added 3 commits July 20, 2020 17:27
to handle target frameworks.
Support broader -o extensions
Allow missing .nuspec
@cleemullins cleemullins merged commit 3786d10 into master Jul 29, 2020
@cleemullins cleemullins deleted the chrimc/schema branch July 29, 2020 19:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants